Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: melos #987

Merged
merged 3 commits into from
Mar 22, 2024
Merged

build: melos #987

merged 3 commits into from
Mar 22, 2024

Conversation

altynbek132
Copy link
Contributor

Add mobx_lint_flutter_test package to melos.yaml
update melos dev dependency to version 5.2.1

Copy link

netlify bot commented Mar 21, 2024

‼️ Deploy request for mobx rejected.

Name Link
🔨 Latest commit 8b58080

Copy link
Member

@pavanpodila pavanpodila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the command. Looks good otherwise

@@ -16,7 +17,3 @@ scripts:
exec: dart run $MELOS_ROOT_PATH/tool/expose_version.dart
generate:
run: cd mobx_examples && dart run build_runner watch --delete-conflicting-outputs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required to work locally. We should not remove this

Copy link
Contributor Author

@altynbek132 altynbek132 Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this options has been removed in melos 3.1.1, isn't it?
https://github.com/invertase/melos/blob/melos-v3.1.1/docs/guides/migrations.mdx#L55

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome .. didn't know that ...

@altynbek132 altynbek132 changed the title Pr melos ci: melos Mar 22, 2024
@altynbek132 altynbek132 changed the title ci: melos build: melos Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (0768592) to head (b30312e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #987   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          57       57           
  Lines        2024     2024           
=======================================
  Hits         2004     2004           
  Misses         20       20           
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.56% <ø> (ø)
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0768592...b30312e. Read the comment docs.

@pavanpodila pavanpodila merged commit e0b4069 into mobxjs:main Mar 22, 2024
11 of 12 checks passed
@pavanpodila
Copy link
Member

@all-contributors add @altynbek132 for code

Copy link
Contributor

@pavanpodila

I've put up a pull request to add @altynbek132! 🎉

@altynbek132 altynbek132 deleted the pr_melos branch March 23, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants